Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Subscriptions model 6/6 #28675

Merged
merged 8 commits into from Mar 30, 2023
Merged

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Mar 29, 2023

ARCH-931

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 29, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #28675 (e92476a) into develop (35499f5) will increase coverage by 4.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28675      +/-   ##
===========================================
+ Coverage    40.36%   45.20%   +4.84%     
===========================================
  Files          727      748      +21     
  Lines        14306    14524     +218     
  Branches      2203     2240      +37     
===========================================
+ Hits          5774     6566     +792     
+ Misses        8242     7651     -591     
- Partials       290      307      +17     
Flag Coverage Δ
e2e 45.16% <ø> (+4.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 29, 2023
@KevLehman KevLehman marked this pull request as ready for review March 29, 2023 14:27
@KevLehman KevLehman requested review from a team as code owners March 29, 2023 14:27
ggazzo
ggazzo previously approved these changes Mar 30, 2023
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Mar 30, 2023
@ggazzo ggazzo merged commit f27765c into develop Mar 30, 2023
35 checks passed
@ggazzo ggazzo deleted the refactor/subscriptions-model-6 branch March 30, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants