refactor(client): enter-room callback hook
#28704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
changed the title
enter-room callback hookenter-room callback hook
Codecov Report
@@ Coverage Diff @@
## develop #28704 +/- ##
========================================
Coverage 45.23% 45.24%
========================================
Files 743 742 -1
Lines 14482 14478 -4
Branches 2239 2238 -1
========================================
- Hits 6551 6550 -1
+ Misses 7625 7621 -4
- Partials 306 307 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
force-pushed
the
refactor/drop-enter-room-callback
branch
4 times, most recently
from
f55da43
to
121abfc
Compare
tassoevan
force-pushed
the
refactor/drop-enter-room-callback
branch
from
121abfc
to
6dd72cc
Compare
ggazzo
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments