Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve change stream error handler #29195

Merged
merged 1 commit into from May 12, 2023

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented May 10, 2023

SUP-23

Proposed changes (including videos or screenshots)

I flagged as a breaking change since now it will halt the process after 5 retries.

Issue(s)

ARCH-1093

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team May 10, 2023 01:19
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #29195 (4a4837f) into release-6.2.0 (a341729) will decrease coverage by 0.05%.
The diff coverage is 50.64%.

❗ Current head 4a4837f differs from pull request most recent head b869081. Consider uploading reports for the commit b869081 to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.2.0   #29195      +/-   ##
=================================================
- Coverage          46.92%   46.88%   -0.05%     
=================================================
  Files                729      710      -19     
  Lines              13876    13224     -652     
  Branches            2196     2197       +1     
=================================================
- Hits                6512     6200     -312     
+ Misses              7049     6712     -337     
+ Partials             315      312       -3     
Flag Coverage Δ
e2e 46.84% <50.64%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ggazzo
ggazzo previously approved these changes May 11, 2023
@ggazzo ggazzo added this to the 6.2.0 milestone May 12, 2023
@ggazzo ggazzo changed the base branch from develop to release-6.2.0 May 12, 2023 18:12
@ggazzo ggazzo dismissed their stale review May 12, 2023 18:12

The base branch was changed.

@ggazzo ggazzo requested review from a team as code owners May 12, 2023 18:12
@ggazzo ggazzo changed the base branch from release-6.2.0 to develop May 12, 2023 18:12
@sampaiodiego sampaiodiego changed the base branch from develop to release-6.2.0 May 12, 2023 19:45
@ggazzo ggazzo changed the title chore!: improve change stream error handler chore: improve change stream error handler May 12, 2023
@ggazzo ggazzo merged commit 07af6a2 into release-6.2.0 May 12, 2023
7 checks passed
@ggazzo ggazzo deleted the improve-change-error-handler branch May 12, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants