regression: Fix monitor validation logic for rooms & departments #29213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtaza98
previously approved these changes
May 11, 2023
Codecov Report
@@ Coverage Diff @@
## release-6.2.0 #29213 +/- ##
=================================================
+ Coverage 44.66% 46.87% +2.21%
=================================================
Files 682 729 +47
Lines 12737 13876 +1139
Branches 2058 2196 +138
=================================================
+ Hits 5689 6505 +816
- Misses 6766 7057 +291
- Partials 282 314 +32
Flags with carried forward coverage won't be shown. Click here to find out more. |
tapiarafael
previously approved these changes
May 11, 2023
KevLehman
force-pushed
the
regression/monitor-validation-units-not-applied
branch
from
c50dc97
to
539e863
Compare
KevLehman
force-pushed
the
regression/monitor-validation-units-not-applied
branch
from
539e863
to
bf1011a
Compare
dionisio-bot
bot
added
stat: ready to merge
sampaiodiego
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OC-939
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Notes:
The ideal solution is to move that query override logic outside of the models, like we do for departments. This way, we would be able to remove the
Promise.awaiton this PR