Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Files menu ignores new server address #29620

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Rottenblasters
Copy link
Contributor

@Rottenblasters Rottenblasters commented Jun 22, 2023

Proposed changes (including videos or screenshots)

This PR fixes the issue #29516 .

Link to Attachment
Screenshot (1)

Files Menu Link
Screenshot (2)

Basically in Files Menu, below was the fileItem response which was being sent
Screenshot (3)

  • As you can see there is a url field which contains the absolute URL to the file (basically it stores the URL at the time the file was uploaded, which in this case was when the server was at port 3000).
  • Previously we were using this field as the url parameter in the component, hence when the server port was changed it would show the port at which the file was uploaded.
  • I have changed this so that the url parameter gets the path field instead which stores the relative URL hence solving the issue

Issue(s)

Closes #29516

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

⚠️ No Changeset found

Latest commit: 668057d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rottenblasters Rottenblasters marked this pull request as ready for review June 22, 2023 09:06
@Rottenblasters Rottenblasters requested a review from a team as a code owner June 22, 2023 09:06
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #29620 (668057d) into develop (baaa38f) will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29620      +/-   ##
===========================================
+ Coverage    45.82%   46.55%   +0.72%     
===========================================
  Files          679      692      +13     
  Lines        12839    12926      +87     
  Branches      2220     2238      +18     
===========================================
+ Hits          5884     6018     +134     
+ Misses        6637     6585      -52     
- Partials       318      323       +5     
Flag Coverage Δ
e2e 46.52% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@olodar
Copy link

olodar commented May 23, 2024

Hi, when this bug will be fixed? It's actually fixed already, why don't you want merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Files menu ignores new server address
4 participants