-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Files menu ignores new server address #29620
base: develop
Are you sure you want to change the base?
fix: Files menu ignores new server address #29620
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #29620 +/- ##
===========================================
+ Coverage 45.82% 46.55% +0.72%
===========================================
Files 679 692 +13
Lines 12839 12926 +87
Branches 2220 2238 +18
===========================================
+ Hits 5884 6018 +134
+ Misses 6637 6585 -52
- Partials 318 323 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hi, when this bug will be fixed? It's actually fixed already, why don't you want merge? |
Proposed changes (including videos or screenshots)
This PR fixes the issue #29516 .
Link to Attachment
![Screenshot (1)](https://private-user-images.githubusercontent.com/68077049/247879078-e75d9630-7fac-415a-9542-5056fa61f3f0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIwMjMyNzUsIm5iZiI6MTcyMjAyMjk3NSwicGF0aCI6Ii82ODA3NzA0OS8yNDc4NzkwNzgtZTc1ZDk2MzAtN2ZhYy00MTVhLTk1NDItNTA1NmZhNjFmM2YwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI2VDE5NDI1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk1ZmM1ZjM0YWU5YjQzZDc4OWE3YTU0NjdiZTUzNzdkZDMyODA3ZmY3NTFiOTEwZDJjMjE3YTFlMjNmY2ZlMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XA1XcQRcsxzkY1OEG3JpgMcndprOLqepgcUNkHPaGzY)
Files Menu Link
![Screenshot (2)](https://private-user-images.githubusercontent.com/68077049/247879113-9da2d546-4a8e-48c6-ab69-32e1d4521ae7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIwMjMyNzUsIm5iZiI6MTcyMjAyMjk3NSwicGF0aCI6Ii82ODA3NzA0OS8yNDc4NzkxMTMtOWRhMmQ1NDYtNGE4ZS00OGM2LWFiNjktMzJlMWQ0NTIxYWU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI2VDE5NDI1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkyY2JmYjhhNzQ5ODRmOTAzMzQ0NjZiMTVjMDRlZTM4OTc0NWE5MDg4YTc3ZDU3NTU4N2RlMzg2MzIyNTkwNTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Jv-QaOUIdAadHC0cNhx-pSxzFjDI97peJefl1NdH0v4)
Basically in Files Menu, below was the
![Screenshot (3)](https://private-user-images.githubusercontent.com/68077049/247879788-d25244e1-8593-4312-b079-75d56a8f7552.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIwMjMyNzUsIm5iZiI6MTcyMjAyMjk3NSwicGF0aCI6Ii82ODA3NzA0OS8yNDc4Nzk3ODgtZDI1MjQ0ZTEtODU5My00MzEyLWIwNzktNzVkNTZhOGY3NTUyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI2VDE5NDI1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYxNGI5NjRiNmU0ODRkMDhlM2Y4Y2Y0OWYyMTFkNTlmNWRkYWRiOWM1N2QyYWZmNGMzMGUzNTgwZTM2ODQ1NDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xz7NG9nfV6aBQo7dX0p4jXy1PynVyIfK2X8ZsxidKfQ)
fileItem
response which was being senturl
field which contains the absolute URL to the file (basically it stores the URL at the time the file was uploaded, which in this case was when the server was atport 3000
).url parameter
in the component, hence when the server port was changed it would show the port at which the file was uploaded.url parameter
gets thepath
field instead which stores the relative URL hence solving the issueIssue(s)
Closes #29516
Steps to test or reproduce
Further comments