fix(meteor): room-opened event not dispatching when navigating cached rooms
#29718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f3b18f The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #29718 +/- ##
============================================
+ Coverage 31.33% 46.61% +15.28%
============================================
Files 570 693 +123
Lines 10839 12948 +2109
Branches 1993 2242 +249
============================================
+ Hits 3396 6036 +2640
+ Misses 7229 6586 -643
- Partials 214 326 +112
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
approved these changes
Jul 4, 2023
sampaiodiego
pushed a commit
that referenced
this pull request
Jul 5, 2023
gabriellsh
added a commit
that referenced
this pull request
Jul 12, 2023
…/reportUser * 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits) feat: Add missing variants to UIKit button (#29654) refactor: Remove Accountbox usage (#29786) chore: stop importing action manager as global (#29766) chore: create FeaturePreview Component (#29759) regression: add missing translations on MenuV2 replace (#29777) test: create mock package (#29765) fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756) regression: option to start video conferences disappearing for regular users (#29763) Release 6.2.9 Revert "Release 6.2.9" fix(meteor): `room-opened` event not dispatching when navigating cached rooms (#29718) chore: device management improve readability and performance (#29712) chore: throttle exceptions counter increment (#29719) chore: Improve performance of getActiveLocalUserCount (#29681) Release 6.2.9 ci: update EE license (#29684) ci: Add missing `context` property on compose file (#29676) chore: add change stream option to get full doc (#29627) fix(meteor): Message composer keeps recording even though permission was denied (#29526) fix(meteor): Video Record button disabled on iOS browsers (#29649) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Run this event every time the room is changed.
Issue(s)
SUP-251
Steps to test or reproduce
Further comments