Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hide chat console during verification process in Omnichannel rooms #30123

Conversation

bhardwajdisha
Copy link
Contributor

Proposed changes (including videos or screenshots)

During the omnichannel verification process, the chat console will be concealed, and in its place, a message footer will be presented. This footer will include a "Cancel Verification" button.

2.Rocket.Chat.-.Google.Chrome.2023-08-19.20-51-42.mp4

Issue(s)

Steps to test or reproduce

  1. Go to omnichannel, join an open room
  2. Click on verify user button from quick action buttons.

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2023

⚠️ No Changeset found

Latest commit: ca75dfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #30123 (938f592) into gsoc-livechat-2FA-feature-branch (b6daa25) will increase coverage by 30.76%.
The diff coverage is n/a.

❗ Current head 938f592 differs from pull request most recent head ca75dfa. Consider uploading reports for the commit ca75dfa to get more accurate results

Impacted file tree graph

@@                          Coverage Diff                          @@
##           gsoc-livechat-2FA-feature-branch   #30123       +/-   ##
=====================================================================
+ Coverage                             35.36%   66.13%   +30.76%     
=====================================================================
  Files                                   598       66      -532     
  Lines                                 12008     1559    -10449     
  Branches                               2262      343     -1919     
=====================================================================
- Hits                                   4247     1031     -3216     
+ Misses                                 7517      468     -7049     
+ Partials                                244       60      -184     
Flag Coverage Δ
e2e ?
unit 66.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 merged commit 785cf6d into RocketChat:gsoc-livechat-2FA-feature-branch Aug 23, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants