Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update type of message bridge's create method #30321

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Sep 7, 2023

Proposed changes (including videos or screenshots)

  • A minor enhancement of types for the message create bridge
  • This absolves us from either calling getById of room bridge, essentially touching the db to satisfy typescript of all the required fields (room id verification is already done in the bridge/converter, so this call would just add overhead without any benefits) or force cast and risk future changes breaking current code

Issue(s)

RocketChat/Rocket.Chat.Apps-engine#660 (comment)

Steps to test or reproduce

Further comments

AECO-360

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: f5cab95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #30321 (f5cab95) into develop (ee3815f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30321      +/-   ##
===========================================
+ Coverage    50.00%   50.01%   +0.01%     
===========================================
  Files          782      782              
  Lines        14521    14521              
  Branches      2623     2623              
===========================================
+ Hits          7261     7263       +2     
+ Misses        6850     6842       -8     
- Partials       410      416       +6     
Flag Coverage Δ
e2e 48.42% <ø> (+0.01%) ⬆️
unit 60.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb
Copy link
Member

Don't think this needs a changeset from core.

debdutdeb
debdutdeb previously approved these changes Sep 8, 2023
Copy link
Member

@debdutdeb debdutdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

maybe remove the changeset, but apps team would be the best people to comment on that .

@Dnouv Dnouv marked this pull request as ready for review September 8, 2023 16:05
@Dnouv Dnouv requested a review from a team as a code owner September 8, 2023 16:05
@casalsgh casalsgh added stat: ready to merge PR tested and approved waiting for merge stat: QA skipped and removed stat: needs QA labels Sep 8, 2023
@kodiakhq kodiakhq bot merged commit 9f6efb1 into develop Sep 8, 2023
42 checks passed
@kodiakhq kodiakhq bot deleted the new/dmnotify branch September 8, 2023 17:55
@casalsgh casalsgh added this to the 6.4.0 milestone Sep 8, 2023
d-gubert added a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants