-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update type of message bridge's create method #30321
Conversation
🦋 Changeset detectedLatest commit: f5cab95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30321 +/- ##
===========================================
+ Coverage 50.00% 50.01% +0.01%
===========================================
Files 782 782
Lines 14521 14521
Branches 2623 2623
===========================================
+ Hits 7261 7263 +2
+ Misses 6850 6842 -8
- Partials 410 416 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Don't think this needs a changeset from core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
maybe remove the changeset, but apps team would be the best people to comment on that .
Proposed changes (including videos or screenshots)
create
bridgeIssue(s)
RocketChat/Rocket.Chat.Apps-engine#660 (comment)
Steps to test or reproduce
Further comments
AECO-360