-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Language selection box is empty which should be default #31312
Conversation
🦋 Changeset detectedLatest commit: ed0f522 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31312 +/- ##
===========================================
- Coverage 49.33% 49.30% -0.03%
===========================================
Files 3299 3299
Lines 81122 81122
Branches 16594 16594
===========================================
- Hits 40020 40000 -20
- Misses 36454 36462 +8
- Partials 4648 4660 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
BEFORE THE FIX
https://github.com/RocketChat/Rocket.Chat/assets/112304873/0fdc1b0f-4e42-4546-87b8-3968e56e1c9c
AFTER THE FIX
https://github.com/RocketChat/Rocket.Chat/assets/112304873/ca4c6cc2-f121-4561-a6ff-5ba1d93a819f
REASON BEHIND CHANGES
The type of 'language' field in default values was string | undefined. When undefined it wont show anything, so we need to use correct type for 'language' which is only 'string' and also if language is undefined(when useUserPreference returns undefiend) we should assign it with blank ''
Issue(s)
This should close issues :-
fix #31307
Steps to test or reproduce
Further comments