Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Marketplace): Install private apps page to TypeScript #31404

Merged
merged 12 commits into from
Jan 19, 2024

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jan 9, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

AECO-476

Copy link

changeset-bot bot commented Jan 9, 2024

⚠️ No Changeset found

Latest commit: 80bc503

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tiagoevanp tiagoevanp changed the title Rewrite/marketplace page rewrite(Marketplace): Install private apps page to TypeScript Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fdd9852) 45.37% compared to head (80bc503) 47.12%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31404      +/-   ##
===========================================
+ Coverage    45.37%   47.12%   +1.74%     
===========================================
  Files         3206     3091     -115     
  Lines        75350    77868    +2518     
  Branches     15336    15927     +591     
===========================================
+ Hits         34193    36692    +2499     
- Misses       36743    36795      +52     
+ Partials      4414     4381      -33     
Flag Coverage Δ
e2e 45.57% <0.00%> (-7.58%) ⬇️
e2e-api 40.69% <0.00%> (-0.01%) ⬇️
unit 76.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp changed the title rewrite(Marketplace): Install private apps page to TypeScript refactor(Marketplace): Install private apps page to TypeScript Jan 9, 2024
@tiagoevanp tiagoevanp marked this pull request as ready for review January 9, 2024 17:58
@tiagoevanp tiagoevanp requested review from a team as code owners January 9, 2024 17:58
csuadev
csuadev previously approved these changes Jan 11, 2024
tiagoevanp and others added 2 commits January 11, 2024 15:06
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
tassoevan
tassoevan previously approved these changes Jan 15, 2024
@tassoevan tassoevan added this to the 6.6 milestone Jan 16, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 19, 2024
@kodiakhq kodiakhq bot merged commit a1d28f7 into develop Jan 19, 2024
46 checks passed
@kodiakhq kodiakhq bot deleted the rewrite/marketplace-page branch January 19, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants