Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Message keyboard navigability #31549

Merged
merged 18 commits into from Feb 20, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jan 26, 2024

Proposed changes (including videos or screenshots)

  • Message focus style
  • Message arrow key navigation
  • Message toolbar arrow key navigation
  • Usercard opens with keys
  • Message focus on Threads

Issue(s)

Closes #31300

Steps to test or reproduce

Further comments

DSAR-428
DSAR-450

Copy link

changeset-bot bot commented Jan 26, 2024

🦋 Changeset detected

Latest commit: 5b5396a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (fe089ff) 54.37% compared to head (5b5396a) 54.40%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31549      +/-   ##
===========================================
+ Coverage    54.37%   54.40%   +0.02%     
===========================================
  Files         2273     2273              
  Lines        50077    50098      +21     
  Branches     10212    10222      +10     
===========================================
+ Hits         27230    27255      +25     
+ Misses       20366    20361       -5     
- Partials      2481     2482       +1     
Flag Coverage Δ
e2e 53.27% <84.12%> (+0.02%) ⬆️
e2e-api 39.85% <ø> (+0.03%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review February 16, 2024 15:43
@dougfabris dougfabris requested a review from a team as a code owner February 16, 2024 15:43
@dougfabris dougfabris force-pushed the feat/message-keyboard-navigation branch from 67f7940 to 1b59c1e Compare February 19, 2024 17:33
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 20, 2024
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Menu

@ggazzo ggazzo merged commit 51f90dc into develop Feb 20, 2024
46 checks passed
@ggazzo ggazzo deleted the feat/message-keyboard-navigation branch February 20, 2024 15:09
@dougfabris dougfabris added this to the 6.7 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not open message action menu using screen reader
2 participants