Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User presence not updating #31723

Merged
merged 4 commits into from Feb 15, 2024
Merged

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Feb 9, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Closes #31705

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner February 9, 2024 21:31
Copy link

changeset-bot bot commented Feb 9, 2024

🦋 Changeset detected

Latest commit: ea85243

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb9c6ba) 54.33% compared to head (ea85243) 54.37%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31723      +/-   ##
===========================================
+ Coverage    54.33%   54.37%   +0.04%     
===========================================
  Files         2276     2273       -3     
  Lines        50124    50078      -46     
  Branches     10220    10213       -7     
===========================================
- Hits         27233    27232       -1     
+ Misses       20406    20362      -44     
+ Partials      2485     2484       -1     
Flag Coverage Δ
e2e 53.19% <100.00%> (+0.01%) ⬆️
e2e-api 39.95% <ø> (+0.11%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

dougfabris
dougfabris previously approved these changes Feb 9, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset pls 😬

@sampaiodiego sampaiodiego merged commit d62505d into develop Feb 15, 2024
43 checks passed
@sampaiodiego sampaiodiego deleted the fix/userPresenceReactivity branch February 15, 2024 18:36
sampaiodiego pushed a commit that referenced this pull request Feb 16, 2024
Co-authored-by: dougfabris <devfabris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status is not correctly updated after update to 6.6.0
3 participants