New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(livechat): hide or change logo #31820
Conversation
🦋 Changeset detectedLatest commit: c20ddbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31820 +/- ##
===========================================
+ Coverage 54.70% 54.74% +0.03%
===========================================
Files 2291 2299 +8
Lines 50618 50733 +115
Branches 10337 10360 +23
===========================================
+ Hits 27690 27773 +83
- Misses 20443 20465 +22
- Partials 2485 2495 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
b201ec2
to
37a209f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of creating a tag property and spreading it across all components (as well as the respective margins) why not pass it through the label property?
e6ed8ff
to
e9b41f8
Compare
afaaa08
to
ed7001b
Compare
0f10639
to
7f92be1
Compare
0636587
1ec991c
to
0636587
Compare
80d6c61
to
a3a807e
Compare
a3a807e
to
c20ddbf
Compare
Proposed changes (including videos or screenshots)
This PR adds two new Livechat settings:
ℹ️ Tests for both settings will be implemented in separate tasks : PROSVC-80 and PROSVC-81
Issue(s)
PROSVC-48
Steps to test or reproduce
Further comments