Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(livechat): hide or change logo #31820

Merged
merged 11 commits into from Mar 25, 2024
Merged

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Feb 23, 2024

Proposed changes (including videos or screenshots)

This PR adds two new Livechat settings:

Name Type Description
Hide "powered by Rocket.Chat" boolean Hides Rocket.Chat's watermark in Livechat.
Livechat logo asset Changes the Livechat widget logo

ℹ️ Tests for both settings will be implemented in separate tasks : PROSVC-80 and PROSVC-81

Issue(s)

PROSVC-48

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: c20ddbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/livechat Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.74%. Comparing base (9d23d40) to head (c20ddbf).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31820      +/-   ##
===========================================
+ Coverage    54.70%   54.74%   +0.03%     
===========================================
  Files         2291     2299       +8     
  Lines        50618    50733     +115     
  Branches     10337    10360      +23     
===========================================
+ Hits         27690    27773      +83     
- Misses       20443    20465      +22     
- Partials      2485     2495      +10     
Flag Coverage Δ
e2e 53.72% <ø> (+0.03%) ⬆️
e2e-api 40.12% <ø> (-0.01%) ⬇️
unit 75.81% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva force-pushed the feat/livechat-hide-change-logo branch 2 times, most recently from b201ec2 to 37a209f Compare February 27, 2024 16:15
@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 27, 2024 18:46
.changeset/clean-cars-teach.md Outdated Show resolved Hide resolved
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of creating a tag property and spreading it across all components (as well as the respective margins) why not pass it through the label property?

apps/meteor/app/livechat/server/api/lib/livechat.ts Outdated Show resolved Hide resolved
apps/meteor/server/settings/omnichannel.ts Outdated Show resolved Hide resolved
Base automatically changed from hooks-ts to develop February 29, 2024 13:13
@aleksandernsilva aleksandernsilva marked this pull request as draft February 29, 2024 14:16
@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 1, 2024 14:19
apps/meteor/server/settings/omnichannel.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/api/lib/livechat.ts Outdated Show resolved Hide resolved
@aleksandernsilva aleksandernsilva marked this pull request as draft March 7, 2024 20:41
@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 7, 2024 22:26
@aleksandernsilva aleksandernsilva changed the base branch from develop to fix/ee-settings March 13, 2024 12:57
@aleksandernsilva aleksandernsilva marked this pull request as draft March 13, 2024 12:58
@aleksandernsilva aleksandernsilva force-pushed the feat/livechat-hide-change-logo branch 2 times, most recently from 0f10639 to 7f92be1 Compare March 13, 2024 13:04
Base automatically changed from fix/ee-settings to develop March 14, 2024 14:19
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Mar 22, 2024
tassoevan
tassoevan previously approved these changes Mar 22, 2024
KevLehman
KevLehman previously approved these changes Mar 22, 2024
@ggazzo ggazzo dismissed stale reviews from KevLehman and tassoevan via a3a807e March 22, 2024 21:45
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 22, 2024
@ggazzo ggazzo force-pushed the feat/livechat-hide-change-logo branch from 80d6c61 to a3a807e Compare March 22, 2024 21:54
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 22, 2024
@ggazzo ggazzo changed the title feat: Livechat hide or change logo feat(livechat): hide or change logo Mar 22, 2024
@ggazzo ggazzo force-pushed the feat/livechat-hide-change-logo branch from a3a807e to c20ddbf Compare March 22, 2024 23:26
@ggazzo ggazzo merged commit 3eb4dd7 into develop Mar 25, 2024
43 checks passed
@ggazzo ggazzo deleted the feat/livechat-hide-change-logo branch March 25, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants