Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(federation-v2): do not load registration.yaml file in container #32012

Merged
merged 22 commits into from Mar 19, 2024

Conversation

debdutdeb
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@debdutdeb debdutdeb requested a review from a team as a code owner March 17, 2024 15:29
Copy link

changeset-bot bot commented Mar 17, 2024

🦋 Changeset detected

Latest commit: 54bfc04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 54.63%. Comparing base (d0259a8) to head (047f3f5).

❗ Current head 047f3f5 differs from pull request most recent head 54bfc04. Consider uploading reports for the commit 54bfc04 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32012      +/-   ##
===========================================
- Coverage    54.64%   54.63%   -0.02%     
===========================================
  Files         2294     2293       -1     
  Lines        50597    50573      -24     
  Branches     10321    10312       -9     
===========================================
- Hits         27649    27629      -20     
+ Misses       20455    20453       -2     
+ Partials      2493     2491       -2     
Flag Coverage Δ
e2e 53.65% <ø> (-0.05%) ⬇️
e2e-api 40.14% <75.00%> (+0.02%) ⬆️
unit 75.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb debdutdeb requested a review from a team as a code owner March 17, 2024 20:03
@debdutdeb debdutdeb changed the title chore: don't load registration data from mounted file chore: misc federation changes to increase reliability Mar 17, 2024
@sampaiodiego sampaiodiego added this to the 6.7 milestone Mar 18, 2024
@debdutdeb debdutdeb changed the title chore: misc federation changes to increase reliability chore(federation-v2): do not load registration.yaml file in container Mar 18, 2024
sampaiodiego
sampaiodiego previously approved these changes Mar 18, 2024
@sampaiodiego sampaiodiego merged commit 5c4a972 into develop Mar 19, 2024
7 of 8 checks passed
@sampaiodiego sampaiodiego deleted the fix/federationV2-misc branch March 19, 2024 13:42
sampaiodiego pushed a commit that referenced this pull request Mar 19, 2024
…#32012)

Co-authored-by: Marcos Defendi <marcos.defendi@rocket.chat>
This was referenced Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants