Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal server error when connecting to publication with backward compatibility flag #32085

Merged
merged 2 commits into from Mar 28, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

SUP-463

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: 8539364

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.75%. Comparing base (0b1a360) to head (0bdd5ed).

❗ Current head 0bdd5ed differs from pull request most recent head d364e56. Consider uploading reports for the commit d364e56 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.7.0   #32085      +/-   ##
=================================================
+ Coverage          53.67%   54.75%   +1.07%     
=================================================
  Files               2227     2298      +71     
  Lines              49512    50708    +1196     
  Branches           10085    10374     +289     
=================================================
+ Hits               26575    27764    +1189     
+ Misses             20515    20452      -63     
- Partials            2422     2492      +70     
Flag Coverage Δ
e2e 53.74% <100.00%> (+2.10%) ⬆️
e2e-api 40.12% <ø> (-0.04%) ⬇️
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review March 27, 2024 19:14
@sampaiodiego sampaiodiego changed the base branch from develop to release-6.7.0 March 28, 2024 20:08
@sampaiodiego sampaiodiego requested review from a team as code owners March 28, 2024 20:08
@sampaiodiego sampaiodiego force-pushed the fix/back-compatibility-realtime-api branch from 0bdd5ed to d364e56 Compare March 28, 2024 20:09
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 28, 2024
@kodiakhq kodiakhq bot merged commit a7b50ec into release-6.7.0 Mar 28, 2024
11 of 12 checks passed
@kodiakhq kodiakhq bot deleted the fix/back-compatibility-realtime-api branch March 28, 2024 20:11
@sampaiodiego sampaiodiego added this to the 6.7 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants