Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Italic for decimal numbers and strings with one dot ( #31920) #32146

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

joanamarquees
Copy link

Proposed changes (including videos or screenshots)

The conversion of decimal numbers to italics wasn't working. After testing several italic conversions, I realised that the problem occurred when putting numbers with just a dot in the middle or even words containing a dot. I then realised that this was because the text was being parsed according to another rule included in the grammar.pegjs file.

After looking at various solutions, I was able to come up with a proposal that solves the initial problem. The rule blocking the conversion was the AutoLink, so now the autoLink verifies if it is supposed to be an italic conversion or if it is a link.

Issue(s)

#31920

Steps to test or reproduce

Steps already described on the issue page.

Copy link
Contributor

dionisio-bot bot commented Apr 6, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project
    Please fix the issues and try again
    If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 6, 2024

⚠️ No Changeset found

Latest commit: 96ddfb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joanamarquees joanamarquees marked this pull request as draft April 6, 2024 15:50
@joanamarquees joanamarquees marked this pull request as ready for review April 6, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant