Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove hipchat importer #32154

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

It's been half a decade since hipchat was discontinued. It's time.

Copy link
Contributor

dionisio-bot bot commented Apr 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: 503060c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc added this to the 7.0 milestone Apr 8, 2024
@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge and removed stat: QA skipped stat: ready to merge PR tested and approved waiting for merge labels Apr 8, 2024
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review April 8, 2024 19:29
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners April 8, 2024 19:29
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.81%. Comparing base (3dd2183) to head (503060c).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #32154      +/-   ##
=================================================
- Coverage          54.84%   53.81%   -1.03%     
=================================================
  Files               2306     2231      -75     
  Lines              50912    49839    -1073     
  Branches           10417    10212     -205     
=================================================
- Hits               27922    26822    -1100     
- Misses             20481    20600     +119     
+ Partials            2509     2417      -92     
Flag Coverage Δ
e2e 51.84% <ø> (-1.97%) ⬇️
unit 75.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc added the do not merge Prevent a PR from being automatically merged label Apr 8, 2024
@pierre-lehnen-rc pierre-lehnen-rc changed the base branch from develop to release-7.0.0 April 8, 2024 19:46
@pierre-lehnen-rc pierre-lehnen-rc removed the do not merge Prevent a PR from being automatically merged label Apr 8, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 9, 2024
pierre-lehnen-rc and others added 3 commits April 9, 2024 14:28
@ggazzo ggazzo force-pushed the chore/remove-hipchat-importer branch from 213c22e to 6bdefd4 Compare April 9, 2024 17:28
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 9, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 9, 2024
@ggazzo ggazzo merged commit ebd4586 into release-7.0.0 Apr 11, 2024
44 of 45 checks passed
@ggazzo ggazzo deleted the chore/remove-hipchat-importer branch April 11, 2024 15:00
ggazzo pushed a commit that referenced this pull request Apr 11, 2024
ggazzo pushed a commit that referenced this pull request Apr 11, 2024
ggazzo pushed a commit that referenced this pull request Apr 11, 2024
ggazzo pushed a commit that referenced this pull request Apr 12, 2024
ggazzo pushed a commit that referenced this pull request Apr 12, 2024
ggazzo pushed a commit that referenced this pull request Apr 20, 2024
ggazzo pushed a commit that referenced this pull request Apr 24, 2024
ggazzo pushed a commit that referenced this pull request Apr 24, 2024
ggazzo pushed a commit that referenced this pull request May 7, 2024
ggazzo pushed a commit that referenced this pull request May 9, 2024
ggazzo pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants