-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Omnichannel): Omnichannel agent take it
button
#32175
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 148124a The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32175 +/- ##
===========================================
- Coverage 56.38% 56.34% -0.05%
===========================================
Files 2434 2434
Lines 53693 53702 +9
Branches 11050 11054 +4
===========================================
- Hits 30275 30257 -18
- Misses 20779 20801 +22
- Partials 2639 2644 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
should user not take the chat when offline status
flaky test
apps/meteor/client/views/room/composer/ComposerOmnichannel/ComposerOmnichannelInquiry.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/composer/ComposerOmnichannel/ComposerOmnichannelInquiry.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/composer/ComposerOmnichannel/ComposerOmnichannelInquiry.tsx
Outdated
Show resolved
Hide resolved
|
||
// Note: this is different from openChat because queued chats are not searchable | ||
getQueuedChat(name: string): Locator { | ||
return this.page.locator('[data-qa="sidebar-item-title"]', { hasText: name }).first(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
148124a
Proposed changes (including videos or screenshots)
"Take it" button should be disabled when agent status is set to offline
Issue(s)
Steps to test or reproduce
Further comments
CORE-256