Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Omnichannel): Omnichannel agent take it button #32175

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Apr 10, 2024

Proposed changes (including videos or screenshots)

"Take it" button should be disabled when agent status is set to offline

image

Issue(s)

Steps to test or reproduce

Further comments

CORE-256

Copy link
Contributor

dionisio-bot bot commented Apr 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 148124a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tiagoevanp tiagoevanp modified the milestones: 7.0, 6.8 Apr 10, 2024
@tiagoevanp tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Apr 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 56.34%. Comparing base (cd96032) to head (148124a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32175      +/-   ##
===========================================
- Coverage    56.38%   56.34%   -0.05%     
===========================================
  Files         2434     2434              
  Lines        53693    53702       +9     
  Branches     11050    11054       +4     
===========================================
- Hits         30275    30257      -18     
- Misses       20779    20801      +22     
- Partials      2639     2644       +5     
Flag Coverage Δ
e2e 55.99% <50.00%> (-0.08%) ⬇️
unit 72.30% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp changed the title test(Omnichannel): Fix omnichannel take chat test test(Omnichannel): Fix omnichannel should user not take the chat when offline status flaky test Apr 10, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 10, 2024
@tiagoevanp tiagoevanp marked this pull request as ready for review April 10, 2024 21:13
@tiagoevanp tiagoevanp requested a review from a team as a code owner April 10, 2024 21:13
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 10, 2024
@tassoevan tassoevan added stat: needs QA stat: QA skipped and removed stat: QA assured Means it has been tested and approved by a company insider stat: needs QA labels Apr 10, 2024
@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge stat: QA skipped labels Apr 11, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 11, 2024
KevLehman
KevLehman previously approved these changes May 24, 2024
@tiagoevanp tiagoevanp requested a review from ggazzo May 24, 2024 17:44
KevLehman
KevLehman previously approved these changes May 27, 2024

// Note: this is different from openChat because queued chats are not searchable
getQueuedChat(name: string): Locator {
return this.page.locator('[data-qa="sidebar-item-title"]', { hasText: name }).first();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tiagoevanp tiagoevanp dismissed stale reviews from KevLehman and MarcosSpessatto via 148124a May 27, 2024 19:49
@scuciatto scuciatto added this to the 6.10 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants