feat(E2EE): Async E2EE keys exchange

[yash-rajpal]

Proposed changes (including videos or screenshots)

Async key distribution process for E2EE rooms. Earlier users needed to be online to receive and share and verify the group keys which caused a bottleneck in the process. Made this process async so that users now no longer need to be online at the same time.

Keys will be generated even when the users are offline and they can receive it when they come online.

Issue(s)

Steps to test or reproduce

• Add a few users in an E2EE room
• reset the E2EE for few users
• Log back in with those users (just to create their public keys)
• When the main users comes online in the E2EE room, it will generate the keys for all the users waiting in queue.
• When users come online they receive keys and E2EE rooms messages are decrypted.

Further comments

E2EE-13

[changeset-bot]

🦋 Changeset detected

Latest commit: dcd8fe9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/model-typings	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor
@rocket.chat/meteor	Minor
@rocket.chat/apps	Patch
@rocket.chat/models	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/omnichannel-services	Patch
rocketchat-services	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/web-ui-registration	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

Attention: Patch coverage is 59.55882% with 55 lines in your changes missing coverage. Please review.

Project coverage is 56.71%. Comparing base (1240c87) to head (dcd8fe9).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32197      +/-   ##
===========================================
- Coverage    56.74%   56.71%   -0.03%     
===========================================
  Files         2495     2496       +1     
  Lines        55237    55360     +123     
  Branches     11434    11455      +21     
===========================================
+ Hits         31345    31400      +55     
- Misses       21196    21255      +59     
- Partials      2696     2705       +9     

Flag	Coverage Δ
e2e	56.45% <59.55%> (-0.06%)	⬇️
unit	71.86% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

I still have some general comments:

• Let's improve the PR description.
• We need to add a changeset.
• We can have some API tests to test at least half of the workflow, we can call the provideUsersGroupKeys endpoint with arbitrary values for keys, and see if the keys were set to the subscriptions. Of course, the test will not be fully complete, and test it using an UI test could potentially create a slow test, since the process is completely async.

[hugocostadev]

There are three i18n keys that explain the old behavior about at least one online user, can we remove that info in the keys?

Keys:

• E2E_Reset_Email_Content
• E2E_Reset_Key_Explanation
• E2E_Reset_Other_Key_Warning

Also, there is new endpoints and new functions, would be very important to cover those with api and unit tests :(

Dismissed