New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: TeamsInfo
in favor of RoomInfo
#32225
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32225 +/- ##
===========================================
- Coverage 55.34% 55.32% -0.03%
===========================================
Files 2318 2314 -4
Lines 51085 51044 -41
Branches 10460 10459 -1
===========================================
- Hits 28273 28238 -35
- Misses 20300 20304 +4
+ Partials 2512 2502 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was doing your review but, maybe let's take this moment to do a more complete refactor, making the RoomInfo component purely visual, then we can introduce one component per room type. This way we avoid having mixed logic between teams and different types of channels.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments