Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: TeamsInfo in favor of RoomInfo #32225

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 16, 2024

Proposed changes (including videos or screenshots)

  • add e2e test

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Apr 16, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 1d592c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 6.8 milestone Apr 16, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 38.00000% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 55.32%. Comparing base (6183ce3) to head (1d592c2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32225      +/-   ##
===========================================
- Coverage    55.34%   55.32%   -0.03%     
===========================================
  Files         2318     2314       -4     
  Lines        51085    51044      -41     
  Branches     10460    10459       -1     
===========================================
- Hits         28273    28238      -35     
- Misses       20300    20304       +4     
+ Partials      2512     2502      -10     
Flag Coverage Δ
e2e 54.65% <35.00%> (-0.07%) ⬇️
unit 75.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing your review but, maybe let's take this moment to do a more complete refactor, making the RoomInfo component purely visual, then we can introduce one component per room type. This way we avoid having mixed logic between teams and different types of channels.

@ggazzo ggazzo modified the milestones: 6.8, 6.6 Apr 18, 2024
@dougfabris dougfabris modified the milestones: 6.6, 7.0 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants