Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fingerprint auto accepted still asks for admin confirmation #32277

Merged
merged 1 commit into from Apr 23, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Apr 19, 2024

Backport of #32202

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner April 19, 2024 23:35
@dionisio-bot dionisio-bot bot requested a review from debdutdeb April 19, 2024 23:35
Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 13ae8fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.6 milestone Apr 19, 2024
Copy link
Contributor Author

dionisio-bot bot commented Apr 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.52%. Comparing base (920153c) to head (13ae8fb).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-6.6.7   #32277   +/-   ##
==============================================
  Coverage          54.51%   54.52%           
==============================================
  Files               2278     2279    +1     
  Lines              50234    50247   +13     
  Branches           10266    10266           
==============================================
+ Hits               27387    27399   +12     
- Misses             20359    20360    +1     
  Partials            2488     2488           
Flag Coverage Δ
e2e 53.36% <ø> (+0.02%) ⬆️
unit 76.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo
Copy link
Member

ggazzo commented Apr 22, 2024

/rebase

@ggazzo
Copy link
Member

ggazzo commented Apr 22, 2024

/bark

Copy link
Contributor Author

dionisio-bot bot commented Apr 22, 2024

woof

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 23, 2024
@ggazzo ggazzo merged commit a6fe910 into release-6.6.7 Apr 23, 2024
45 of 47 checks passed
@ggazzo ggazzo deleted the backport-6.6.7-32202 branch April 23, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants