Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade react to v18 #32288

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

refactor: Upgrade react to v18 #32288

wants to merge 16 commits into from

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: 2e4e467

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Apr 22, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@tassoevan tassoevan force-pushed the refactor/react-18 branch 5 times, most recently from ff55e00 to f566a7d Compare May 2, 2024 19:48
@tassoevan tassoevan force-pushed the refactor/react-18 branch 3 times, most recently from 9640aed to 601b4d2 Compare May 14, 2024 17:14
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 56.42458% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 46.99%. Comparing base (4fd9c4c) to head (2e4e467).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32288      +/-   ##
===========================================
- Coverage    56.33%   46.99%   -9.35%     
===========================================
  Files         2434     1827     -607     
  Lines        53682    43660   -10022     
  Branches     11046     8755    -2291     
===========================================
- Hits         30242    20517    -9725     
- Misses       20795    21243     +448     
+ Partials      2645     1900     -745     
Flag Coverage Δ
e2e 33.92% <55.75%> (-22.08%) ⬇️
unit 72.30% <81.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the title refactor/react-18 refactor: React v18 May 15, 2024
@dougfabris dougfabris added this to the 7.0 milestone May 15, 2024
@dougfabris dougfabris changed the title refactor: React v18 refactor: Upgrade react to v18 May 15, 2024
@tassoevan tassoevan force-pushed the refactor/react-18 branch 2 times, most recently from 38176a2 to 83cd480 Compare May 17, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants