test: Add Omnichannel Business Hours E2E tests #32303
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32303 +/- ##
===========================================
+ Coverage 55.60% 56.13% +0.53%
===========================================
Files 2408 2441 +33
Lines 53023 53730 +707
Branches 10902 11061 +159
===========================================
+ Hits 29483 30164 +681
+ Misses 20931 20926 -5
- Partials 2609 2640 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
apps/meteor/tests/e2e/omnichannel/omnichannel-business-hours.spec.ts
Outdated
Show resolved
Hide resolved
dionisio-bot
bot
added
stat: ready to merge
@MarcosSpessatto I always run the eslint fix in all the files to avoid that, github shows like its disaligned but I don't think it is. |
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
dionisio-bot
bot
added
the
stat: ready to merge
apps/meteor/tests/e2e/omnichannel/omnichannel-business-hours.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-business-hours.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-business-hours.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-business-hours.spec.ts
Outdated
Show resolved
Hide resolved
csuadev
dismissed stale reviews from jessicaschelly and MarcosSpessatto
via
6e1d096
| agent = await createAgent(api, 'user2'); | ||
| await api.post('/settings/Livechat_enable_business_hours', { value: true }).then((res) => expect(res.status()).toBe(200)); | ||
| await api.post('/settings/Livechat_business_hour_type', { value: 'Multiple' }).then((res) => expect(res.status()).toBe(200)); | ||
| }); |
There was a problem hiding this comment.
As I told you yesterday, there's no indentation error I could find here, it only happens here on GH. I ran the ESLint fix in every file I modify. In my editor I even installed extensions to fix indentation yesterday and it couldn't find any indentation errors. If you can find a way to make it look good here pls help me commiting it.
There was a problem hiding this comment.
Yeah, remember we discussed this. Apparently ESLint is not running for e2e tests. Investigating why is out of the scope, but would be good to apply at least manual identation to all of these things.
GH UI affects identation in some cases, but for this case, you can click a file's 3 dot menu and using "view raw" to see how the actual text is there with no UI. You'll find it to be not idented properly.
Can you do a manual fix on the identation for this one? I'll ask why eslint is not running on the eng channel in the meantime 🤗
There was a problem hiding this comment.
But I don't know how to indent it good if I can't see any problems with indentation on both editors I have locally and neither the eslint and prettier extensions. That's why I told you maybe you can help me with that if you see the errors. I only see them on gh. 🙏
There was a problem hiding this comment.
Yup, maybe this one can wait till #32526 is merged 👀
So we have eslint running on these files as well, wdyt?
Add e2e tests to the Business Hours section on Omnichannel.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-394
Steps to test or reproduce
Further comments