Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(E2EEncryption): File encryption support #32316

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Apr 25, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

  • Move msg to inside content
  • Hack to be able to download files on chrome
  • Decide if the APIs will be under room domain
  • Decide what to show when e2ee is disabled (check skipped test)
  • Cronjob to remove temporary files older than X hours
  • Mark uploaded files as temporary
  • Mark as non temporary when sending the message
  • Anonimize file name
  • Decide if content will be string and data
  • Decide if the key info will be inside the attachment info
  • Should simplify the data structure and make it compatible on read?
  • Client generated data:
    • Thumbs?
    • Blurred background?
    • Extra file info? Width, Height
  • Tests
    • Old format

Copy link
Contributor

dionisio-bot bot commented Apr 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 25, 2024

⚠️ No Changeset found

Latest commit: 26e2eb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 35.13514% with 72 lines in your changes are missing coverage. Please review.

Project coverage is 55.57%. Comparing base (190d1de) to head (26e2eb8).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32316      +/-   ##
===========================================
- Coverage    55.59%   55.57%   -0.03%     
===========================================
  Files         2408     2405       -3     
  Lines        52997    53024      +27     
  Branches     10894    10908      +14     
===========================================
+ Hits         29465    29467       +2     
- Misses       20918    20957      +39     
+ Partials      2614     2600      -14     
Flag Coverage Δ
e2e 55.05% <35.13%> (-0.01%) ⬇️
unit 72.88% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok added this to the 6.9 milestone May 9, 2024
apps/meteor/public/enc.js Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants