Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert File Description Encryption #32324

Merged
merged 1 commit into from Apr 30, 2024

Conversation

yash-rajpal
Copy link
Member

Proposed changes (including videos or screenshots)

Reverting File Description encryption PR - #31840

The encryption of file description won't play nicely with new structure of message and file descriptions, idea is to improve this flow and encrypt the whole attachment object and not just the description.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Apr 29, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 29, 2024

⚠️ No Changeset found

Latest commit: 91f4b6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yash-rajpal yash-rajpal added this to the 6.8 milestone Apr 29, 2024
@yash-rajpal yash-rajpal marked this pull request as ready for review April 29, 2024 12:48
@yash-rajpal yash-rajpal requested review from a team as code owners April 29, 2024 12:48
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 55.43%. Comparing base (4cb5792) to head (91f4b6f).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.8.0   #32324      +/-   ##
=================================================
- Coverage          55.46%   55.43%   -0.03%     
=================================================
  Files               2376     2374       -2     
  Lines              52179    52143      -36     
  Branches           10667    10660       -7     
=================================================
- Hits               28941    28907      -34     
+ Misses             20696    20685      -11     
- Partials            2542     2551       +9     
Flag Coverage Δ
e2e 54.76% <70.00%> (-0.05%) ⬇️
unit 75.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit a6a5098 into release-6.8.0 Apr 30, 2024
43 checks passed
@ggazzo ggazzo deleted the revert-file-desc-encryption branch April 30, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants