-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Improve permissions check on LDAP endpoints #32335
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32335 +/- ##
=================================================
+ Coverage 55.56% 55.58% +0.02%
=================================================
Files 2333 2332 -1
Lines 51578 51547 -31
Branches 10526 10520 -6
=================================================
- Hits 28657 28652 -5
+ Misses 20403 20384 -19
+ Partials 2518 2511 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
ldap
endpoints by using thepermissionsRequired
property.Issue(s)
CORE-342
Steps to test or reproduce
Further comments
The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.