Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix bh messing with further tests #32607

Closed
wants to merge 13 commits into from
Closed

test: fix bh messing with further tests #32607

wants to merge 13 commits into from

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 13, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: 4032740

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 47.18%. Comparing base (f5e0d1e) to head (4032740).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32607      +/-   ##
===========================================
- Coverage    56.54%   47.18%   -9.36%     
===========================================
  Files         2484     1573     -911     
  Lines        54743    39337   -15406     
  Branches     11305     7766    -3539     
===========================================
- Hits         30955    18562   -12393     
+ Misses       21106    19106    -2000     
+ Partials      2682     1669    -1013     
Flag Coverage Δ
e2e 29.42% <ø> (-26.79%) ⬇️
unit 72.11% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review June 13, 2024 21:59
@ggazzo ggazzo requested a review from a team as a code owner June 13, 2024 21:59
MartinSchoeler
MartinSchoeler previously approved these changes Jun 14, 2024
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jun 14, 2024
@ggazzo ggazzo closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants