Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Supported Versions misbehaving #32621

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jun 18, 2024

Backport of #32610

@dionisio-bot dionisio-bot bot requested a review from ggazzo June 18, 2024 14:33
Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 7017c97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.9 milestone Jun 18, 2024
Copy link
Contributor Author

dionisio-bot bot commented Jun 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (ce72824) to head (7017c97).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.9.2   #32621      +/-   ##
=================================================
+ Coverage          55.99%   56.01%   +0.02%     
=================================================
  Files               2431     2432       +1     
  Lines              53553    53562       +9     
  Branches           11027    11029       +2     
=================================================
+ Hits               29987    30003      +16     
+ Misses             20963    20927      -36     
- Partials            2603     2632      +29     
Flag Coverage Δ
e2e 55.48% <ø> (+0.01%) ⬆️
unit 72.34% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 18, 2024
@kodiakhq kodiakhq bot merged commit 3253d6d into release-6.9.2 Jun 18, 2024
59 of 60 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.9.2-32610 branch June 18, 2024 16:36
ggazzo added a commit that referenced this pull request Jun 18, 2024
Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant