-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SAML "Overwrite user fullname" setting is not being honored #32628
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: dbd0e88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32628 +/- ##
===========================================
- Coverage 56.54% 56.53% -0.02%
===========================================
Files 2484 2481 -3
Lines 54743 54708 -35
Branches 11305 11298 -7
===========================================
- Hits 30955 30928 -27
+ Misses 21106 21101 -5
+ Partials 2682 2679 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
…at/Rocket.Chat into fix/saml-name-overwrite
…nto fix/saml-name-overwrite
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Expected behavior: the user's full name should only be updated/overwritten in case the "Overwrite user fullname (use idp attribute)" setting is enabled. Otherwise, it shouldn't be changed (even if the username is updated on login).
Current behavior the user's full name is updated regardless of the "Overwrite user fullname (use idp attribute)" setting.
Further comments
SUP-605