Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SAML "Overwrite user fullname" setting is not being honored #32628

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Jun 18, 2024

Proposed changes (including videos or screenshots)

  • Check for SAML "Overwrite user fullname" setting before updating a user identity coming from a SAML login.
  • Add end-to-end tests to validate that names are only overwritten when the setting is enabled (and also to make sure they won't be updated along with the username when the latter is changed)

Issue(s)

Steps to test or reproduce

  1. Create a user in RC;
  2. Login using SAML with a user that has the same name or username (following the "Immutable field name" setting in SAML > General > Behavior ) as the previously created user, but a distinct name;

Expected behavior: the user's full name should only be updated/overwritten in case the "Overwrite user fullname (use idp attribute)" setting is enabled. Otherwise, it shouldn't be changed (even if the username is updated on login).
Current behavior the user's full name is updated regardless of the "Overwrite user fullname (use idp attribute)" setting.

Further comments

SUP-605

@matheusbsilva137 matheusbsilva137 added this to the 6.10 milestone Jun 18, 2024
Copy link
Contributor

dionisio-bot bot commented Jun 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: dbd0e88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.53%. Comparing base (f5e0d1e) to head (dbd0e88).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32628      +/-   ##
===========================================
- Coverage    56.54%   56.53%   -0.02%     
===========================================
  Files         2484     2481       -3     
  Lines        54743    54708      -35     
  Branches     11305    11298       -7     
===========================================
- Hits         30955    30928      -27     
+ Misses       21106    21101       -5     
+ Partials      2682     2679       -3     
Flag Coverage Δ
e2e 56.20% <ø> (-0.01%) ⬇️
e2e-api 41.32% <ø> (-0.04%) ⬇️
unit 72.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scuciatto scuciatto removed this from the 6.10 milestone Jun 19, 2024
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review June 19, 2024 12:23
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner June 19, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants