Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sidepanel to teams create #32868

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jul 23, 2024

SIDE-134

Proposed changes (including videos or screenshots)

The new navigation feature adds the possibility of opening a sidepanel when opening a Team.
The sidepanel can list the team's channels and/or discussions.
This will be a configuration for each team when creating or editing.

This PR prepares the api structure for the upcoming UI.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: 1024624

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.52%. Comparing base (7e8e003) to head (1024624).
Report is 24 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32868      +/-   ##
===========================================
+ Coverage    55.45%   55.52%   +0.07%     
===========================================
  Files         2637     2638       +1     
  Lines        57316    57450     +134     
  Branches     11869    11909      +40     
===========================================
+ Hits         31782    31899     +117     
- Misses       22836    22851      +15     
- Partials      2698     2700       +2     
Flag Coverage Δ
e2e 54.09% <ø> (+0.05%) ⬆️
unit 72.31% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review July 23, 2024 21:03
@juliajforesti juliajforesti requested review from a team as code owners July 23, 2024 21:03
Copy link
Member

@matheusbsilva137 matheusbsilva137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you please add more context in the PR description about how this change should work?

apps/meteor/app/api/server/v1/teams.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants