Disconnect on Cordova Pause and Reconnect on Cordova Resume

[graywolf336]

@RocketChat/core

Closes: RocketChat/Rocket.Chat.Cordova#112

This basically listens for Cordova's pause event and disconnects from the server thus saving background battery usage. Then when Cordova fires resume event we reconnect to the server. This will cause a little bit of delay, but I feel that delay is worth the extra battery life saved.

[marceloschmidt]

Does push notification still work after that?

[TheReal1604]

@marceloschmidt After disabling the mobile background data usage for the rocket.chat app on Android the mobile push notifications work like before. (Because the push notifications come from a system service..)

[sampaiodiego]

My only concern is about this.

I think we should call disconnect() and reconnect() on the existing callbacks to avoid a race condition causing the user not being set away.

[rodrigok]

@graywolf336 did you test this? Solved the battery problem?

[graywolf336]

@sampaiodiego I agree, I didn't see that last night when I looked for existing ones. I will move it to there.

@rodrigok Not yet, I created this pull request so I could make usage of the heroku deployment.

[sampaiodiego]

@graywolf336 you forgot to change the package.js file and change the filename 😉

[graywolf336]

That's what I get for trying to do it fast before I left for work. 👎

[engelgabriel]

We should set a timer, for 5 minutes, before disconnecting. If the user is just going to another app to get some info, he can come back quickly. The 5 minutes can be a user's config.

[rodrigok]

@engelgabriel maybe 1 minute?

[graywolf336]

@engelgabriel I agree with @rodrigok, one minute is probably good enough by default to increase the battery saving this hopefully will enable.

[engelgabriel]

Agreed, 1 minute should be fine. Can you do that @graywolf336?

[graywolf336]

Yes I will take a look at adding that this week.

[graywolf336]

@RocketChat/core Thoughts on this now?

[engelgabriel]

Should we add a issue to turn the time into a setting @graywolf336 ?

[TheReal1604]

Nice! Thanks for your amazing work. @graywolf336 @engelgabriel

[graywolf336]

@engelgabriel Yeah we could, probably should be a personally setting though.

[Sing-Li]

Thanks for keeping the world green , @graywolf336 !

[kevincolten]

I like @graywolf336 's idea, this should be an admin setting.