Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimalistic view #4319

Merged
merged 9 commits into from
Sep 16, 2016
Merged

Minimalistic view #4319

merged 9 commits into from
Sep 16, 2016

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Sep 15, 2016

@RocketChat/core

To see it, just add ?layout=embedded to URL:
image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-4319 September 15, 2016 21:16 Inactive
@rodrigok
Copy link
Member

Screen shoots?

@geekgonecrazy
Copy link
Member

I second that request! 😄

@sampaiodiego
Copy link
Member Author

Screenshot added =)

@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-4319 September 16, 2016 14:11 Inactive
@rodrigok
Copy link
Member

Nice!

@geekgonecrazy
Copy link
Member

geekgonecrazy commented Sep 16, 2016

@sampaiodiego is the purpose to be embeded in pages? If so I propose changing it to embeded=1 I think it'd make more sense to users as to what it actually is.

Because when I thought mini view, I was thinking like everything scaled down, not part of UI stripped away. 😄

@rodrigok
Copy link
Member

@geekgonecrazy or maybe style=embedded or style=mini

@engelgabriel
Copy link
Member

I like layout=embedded

@sampaiodiego
Copy link
Member Author

Changed to ?layout=embedded by popular demand.. also I've created a class to manage better which layout is being used (there is only embedded at the moment)

@engelgabriel engelgabriel merged commit dd47448 into develop Sep 16, 2016
@engelgabriel engelgabriel deleted the minimalistic-view branch September 16, 2016 18:11
@geekgonecrazy
Copy link
Member

@sampaiodiego sorry 😁 Awesome feature though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants