User left message token replacement not working #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grammatical gender change from 6329d07 references 'gender' message field. If field doesn't exist, then username is not replaced. Replaced gender specific translation with non-gender specific call, and removed gender option. Gender specific messages don't seem to be implemented. The 6329d07 commit hardcoded "male" value in other places that used gender specific translation.
rwakida
changed the title
rodrigok
added a commit
that referenced
this pull request
Aug 15, 2015
User left message token replacement not working
|
Thanks @rwakida |
Peym4n
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Sep 10, 2018
* add threads as new room type t to statistic * add some comments + changed roomtype from t to thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #466
Replaces gender specific translation with non-gender translation.
Grammatical gender change from 6329d07
references 'gender' message field. If field doesn't exist, then
username is not replaced.
Gender specific messages don't seem to be implemented. The
6329d07 commit hardcoded "male" value
in other places that used gender specific translation.
Replaced gender specific translation with non-gender specific translation, and
removed gender option.