[NEW] Add option on Channel Settings: Hide Notifications and Hide Unread Room Status (#2707, #2143) #5373
Conversation
|
prints pls 😊 |
|
|
|
I am just a bit worried about the UX... I was expecting mute to be a boolean... we need to review the notifications UI as a whole.. the Unread Alert is also confusing. |
|
Mute should just turn off all kinds of notifications IMO |
|
I think the term "mute" is a little bit odd here, from the screenshots. If you have "Everything" selected, then are you muting everything or are you allowing everything? Same goes for "Nothing" selected, would nothing be muted or would nothing be allowed? |
|
Can we please pick a better wording for this and merge it? Let me know the best wording and I'll fix the conflicts. |
# Conflicts: # packages/rocketchat-push-notifications/client/views/pushNotificationsFlexTab.html # packages/rocketchat-push-notifications/client/views/pushNotificationsFlexTab.js # packages/rocketchat-push-notifications/server/methods/saveNotificationSettings.js # server/publications/subscription.coffee
New options: “Disable Notifications” and “Hide Unread Room Status”.
marceloschmidt
changed the title
|
Changed wording:
Please merge? :) |
# Conflicts: # HISTORY.md # packages/rocketchat-i18n/i18n/en.i18n.json # packages/rocketchat-ui-sidenav/client/channels.coffee # packages/rocketchat-ui-sidenav/client/chatRoomItem.coffee # packages/rocketchat-ui-sidenav/client/combined.coffee # packages/rocketchat-ui-sidenav/client/directMessages.coffee # packages/rocketchat-ui-sidenav/client/privateGroups.coffee # packages/rocketchat-ui-sidenav/client/starredRooms.coffee # packages/rocketchat-ui-sidenav/client/unreadRooms.coffee
marceloschmidt
force-pushed
the
mute-notifications
branch
from
9f89f8e
to
e47a2eb
Compare
|
@sampaiodiego finished solving conflicts. could you and/or @rodrigok review this please? I would like to have it merged. |
rodrigok
changed the title
…t into mute-notifications
@RocketChat/core
Closes #2707
It doesn't cover snooze, but helps #2143.