Fixes #547 where editing channel/group name crashed RoomManager #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nRoom tracker Bug is a side effect of User friendly URLs #18. The commit changed Room subscription based on room id to room name.. It created a new room subscription, but didn't remove the old name from the RoomManager's openedRooms cache. Whenever the tracker ran, an 'undefined' room was returned because the old room name was invalid. Adds code that observes room name changes, closes the old room, and opens the new room via the RoomManager. There is still a small bug where the room name changed message is not displayed to the user who changed the name probably due to the message stream subscribing after the message was sent.
|
I will review ASAP |
|
Hi @rwakida, I tested this PR and seems that the url doesn't change when the name of the current room changes. This can create a lot of problems, mainly with refresh. I think that the better solution is close the current room and redirect user the the new one. I did some tests, you can review here #570 |
|
@rodrigok looks good. thanks. |
Peym4n
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Apr 4, 2019
…on-respond-with-message Add message action to copy message to input as reply
This was referenced Dec 24, 2020
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code that observes room name changes, closes the old room, and
opens the new room via the RoomManager. There is still a small bug
where the room name changed message is not displayed to the user who changed
the name probably due to the message stream subscribing after the message was sent.