Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow livechat managers to transfer chats #6180

Merged
merged 1 commit into from Mar 23, 2017

Conversation

drallgood
Copy link
Contributor

@RocketChat/core

This PR allows livechat managers to transfer chats. Right now, only the active agent is allowed to do that.
Sometimes, those people forget to forward it and just leave it open and it's easier for the manager to simply forward it to someone else than having to ask the active agent to do it.

@RocketChat/core

This PR allows livechat managers to transfer chats. Right now, only the active agent is allowed to do that. 
Sometimes, those people forget to forward it and just leave it open and it's easier for the manager to simply forward it to someone else than having to ask the active agent to do it.
@engelgabriel engelgabriel modified the milestone: 0.54.0 Mar 1, 2017
@sampaiodiego
Copy link
Member

sampaiodiego commented Mar 2, 2017

hey, thanks for this pull request.

currently the dropbox to forward to an user is filtering the current user (as you can see here), so I think we need to change it to not show the current agent, what you think?

@drallgood
Copy link
Contributor Author

@sampaiodiego hmm... yeah, I think hat might make sense. This way the manager could forward it to himself if needed.

@drallgood
Copy link
Contributor Author

@sampaiodiego Any pointers how I can get the currently assigned agent?
So far I haven't been able to access that information in visitorForward.js
It's completely unclear to me, how information flows in this area. Somehow data just shows up???

@sampaiodiego
Copy link
Member

@drallgood oh, looks like we don't have that information on client side 😞

maybe we can merge this as is and improve it after.. is that ok?

@drallgood
Copy link
Contributor Author

@sampaiodiego Sure :)

@engelgabriel
Copy link
Member

@sampaiodiego is this approved?

@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.55.0 Mar 22, 2017
@drallgood
Copy link
Contributor Author

@sampaiodiego
Just noticed that this still hasn't been merged and thus wasn't included in the latest release.

Anything I can do to speed this along? We urgently need this feature

@sampaiodiego
Copy link
Member

hey @drallgood .. we'll start merging the approved PRs tomorrow 😉

@drallgood
Copy link
Contributor Author

@sampaiodiego Alright. Just wanted to check... Thanks for the update 😄

@rodrigok rodrigok merged commit ec34e24 into RocketChat:develop Mar 23, 2017
@drallgood drallgood deleted the patch-1 branch March 23, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants