POC Google Natural Language integration #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
force-pushed
the
google-natural-language-integration
branch
from
2d7a42b
to
76a651f
Compare
sampaiodiego
changed the title
| @@ -612,6 +612,7 @@ | |||
| "Give_the_application_a_name_This_will_be_seen_by_your_users": "Give the application a name. This will be seen by your users.", | |||
| "Global": "Global", | |||
| "GoogleCloudStorage": "Google Cloud Storage", | |||
| "GoogleNaturalLanguage_ServiceAccount_Description": "Service account key JSON file. More information can be found [here](https://cloud.google.com/natural-language/docs/common/auth#set_up_a_service_account)", | |||
There was a problem hiding this comment.
I think we'll eventually need to standardize how we word that. I have used different wording in Google Vision package: Create a server key (JSON format) and paste the JSON content here (yours seems better though)
marceloschmidt
approved these changes
Mar 21, 2017
|
@sampaiodiego can you resolve the conflicts? |
|
@engelgabriel done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #6017
As a POC adds an ASCII face besides room name according to the sentiment of the last message sent on the room:
