New feature: Room announcement #6351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouncement # Conflicts: # packages/rocketchat-piwik/client/trackEvents.js
|
+1 |
graywolf336
suggested changes
Mar 20, 2017
| @@ -22,6 +22,11 @@ | |||
| <span class="room-topic">{{{RocketChatMarkdown roomTopic}}}</span> | |||
| </h2> | |||
| </header> | |||
| {{#if showAnnouncement}} | |||
| <div class="fixed-title announcement"> | |||
There was a problem hiding this comment.
Can you fix this spacing and indentation?
|
@graywolf336 In our team it is required to always be there. Otherwise a simply @ALL would suffice. But I'll see if it's better to have the option to hide it when it's in use. |
rodrigok
approved these changes
Mar 23, 2017
graywolf336
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Users that have room editing privileges can set announcement for the room. Announcements will show on top of the room, just below the room name. Please see the attachment for how the announcement looks like.