Breaking long URLS to prevent overflow #6368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CSS to handle long URL overflow
|
|
sampaiodiego
approved these changes
Mar 20, 2017
karlprieb
suggested changes
Mar 20, 2017
| @@ -258,6 +258,13 @@ input:focus { | |||
| border-radius: 6px; | |||
| padding: 5px; | |||
| float: left; | |||
| word-wrap: break-word; | |||
| word-break: break-word; | |||
| -ms-word-break: break-all; | |||
There was a problem hiding this comment.
I think we don't need this. IE11 can handle word-break already.
There was a problem hiding this comment.
@karlprieb can we enable the less autoprefixer again?
There was a problem hiding this comment.
@karlprieb is this the only concern on this PR? if so, we can edit it to use only work-break and merge it
There was a problem hiding this comment.
@sampaiodiego Of course :)
There was a problem hiding this comment.
Just to clarify, you want the -ms-word-break removed, correct?
karlprieb
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CSS to handle long URL overflow
@RocketChat/core
Closes #6329
Updated box
