Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted getAvatarUrlFromUsername #6496

Merged
merged 3 commits into from Mar 29, 2017
Merged

converted getAvatarUrlFromUsername #6496

merged 3 commits into from Mar 29, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 27, 2017

@RocketChat/core

rodrigok
rodrigok approved these changes Mar 28, 2017
View reviewed changes
packages/rocketchat-ui/getAvatarUrlFromUsername.js Outdated
} else if (Meteor.isCordova) {
path = Meteor.absoluteUrl().replace(/\/$/, '');
}
return `${ path }/avatar/${ (encodeURIComponent(username)) }?_dc=${ random }`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these extra parenthesis?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inherit from old code, removed.

@engelgabriel engelgabriel modified the milestone: 0.55.0 Mar 29, 2017
@engelgabriel engelgabriel merged commit d1ca15b into RocketChat:develop Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggazzo @rodrigok @engelgabriel