Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add customFields in rooms/get method #6564

Merged
merged 1 commit into from
Jul 27, 2017
Merged

[NEW] Add customFields in rooms/get method #6564

merged 1 commit into from
Jul 27, 2017

Conversation

borsdenold
Copy link
Contributor

@borsdenold borsdenold commented Apr 2, 2017

@RocketChat/core
In 'userData' it is available now to see customFields, if this value exists, but in 'rooms/get' is not. I think, that it will be helpful.

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2017

CLA assistant check
All committers have signed the CLA.

@borsdenold
Copy link
Contributor Author

Also, i think, that it will be useful to add subscription on rooms. Now i do it with subsribtion on 'privateHistory'. Is it correct? If so, then maybe add more fields to the result, because now it returns only t, name, msgs, ts, lm, cl ?

@engelgabriel engelgabriel modified the milestone: 0.56.0 Apr 18, 2017
@engelgabriel engelgabriel modified the milestones: 0.56.0, 0.57.0 May 9, 2017
@engelgabriel engelgabriel modified the milestones: 0.57.0, 0.58.0 Jun 19, 2017
@rodrigok rodrigok changed the title add customFields in rooms/get method [NEW] Add customFields in rooms/get method Jul 27, 2017
@rodrigok rodrigok merged commit 8315367 into RocketChat:develop Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants