[FIX] Encode avatar url to prevent CSS injection #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlprieb
approved these changes
Apr 10, 2017
| @@ -6,7 +6,7 @@ | |||
| {{else}} | |||
| <button class="thumb user-card-message" data-username="{{u.username}}" tabindex="1"> | |||
| <div class="avatar"> | |||
| <div class="avatar-image" style="background-image:url({{avatar}});"></div> | |||
There was a problem hiding this comment.
Should we save the URL encoded on the DB?
There was a problem hiding this comment.
I think we can do this in the future, because we will need a migration to do that
There was a problem hiding this comment.
@engelgabriel I don't know now, cuz we save usernames there too, can be a problem
There was a problem hiding this comment.
We could do it in the client. The server should reject malformed messages with a proper error code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core