[NEW] Show full name in mentions if use full name setting enabled #6690
Conversation
There was a problem hiding this comment.
I think the ideal implementation of this is like we did for the other real name implementation (injecting the name just before sending the message to the client) instead of save saving the name on the message object
|
@sampaiodiego I have updated it as per your suggestion |
There was a problem hiding this comment.
@alexbrazier one thing that is still missing is updating already loaded messages on name changes as it was done here. sry for not noticing this before
also what you think about notifications? this is not something I have sure we should change.. on notification text I still get @diego.sampaio but on rendered message I see Diego Sampaio.. what you think?
|
@sampaiodiego Good spot. I have updated it so that mentions change instantly when a user changes their name. I changed notifications to use full name in #3851 Does it not work for you? |
|
oh sorry, I meant the mentions on notifications 😬 |
|
I've made the change to the notification mentions to use real names. |
|
@sampaiodiego Do you want me to make any other changes? |
|
@alexbrazier nope.. looks good =) |
|
@alexbrazier I want to merge this PR, can you fix the conflicts? |
|
@rodrigok Conflicts have been resolved |
@RocketChat/core
Show users full name in mentions instead of username if use real name setting enabled. It will also show username if you hover over name.