Convert markdown to js #6694
Merged
Convert markdown to js #6694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -0,0 +1,5 @@ | |||
| describe('rocketchat:markdown Client', () => { | |||
There was a problem hiding this comment.
In the near future we will replace this with proper unit tests using mocha, so this file can be removed for now.
rodrigok
approved these changes
Apr 18, 2017
|
@ehkasper Thanks for this contribution 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
hey folks, I'm trying to transpile coffee to JS in markdown.
Was getting the following error in the
markdowncode.jsfile:TypeError: Cannot call a class as a function. This usually means the function is being called w/o thenewkeyword. As the class is being passed in some sort of callback, I suppose it's called as a function, so I created a new function there to adapt in those cases.CI is failing due to Jasmine methods not being declared as global. Should I add it to eslintrc?