[FIX] REST API user.update throwing error due to rate limiting #6796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to have this released as a new version due to all calls to the rest api endpoint being broke in the latest versions. |
|
FYI: The error from travis has nothing to do with this pull request, thus a rebuild would be nice to have. |
|
Looks like this is failing due to an error in one of the tests. it expects |
rodrigok
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core the rest api
users.updatewas throwing an error due to the update of the rate limit functions due to the call to theRocketChat.setUsernamefunction not being ran as the calling user.Closes #6787