[NEW] Make channels.info accept roomName, just like groups.info #6827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reist
force-pushed
the
channel-info-by-name
branch
from
2731815
to
0f029e4
Compare
|
I don't really see how that Travis failure relates to my changes. |
|
I agree, I've requested a new build of it. |
graywolf336
approved these changes
Apr 27, 2017
There was a problem hiding this comment.
Thanks for this. Do you mind also opening a pull request to add this information to our api documentation? https://github.com/RocketChat/Rocket.Chat.Docs
engelgabriel
approved these changes
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nicer and makes it much easier to write a shared API code base for both.