[New] Snap arm support #6842
Merged
[New] Snap arm support #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elespike can you take a look and see what you think? |
|
@geekgonecrazy Changes look good, I didn't see any problems. |
|
Awesome! I'll push a few more changes I made during debugging. Then get this merged! |
elespike
reviewed
May 3, 2017
.snapcraft/resources/restoredb
Outdated
| backup_file=${1} | ||
| if [[ ! -f ${backup_file} ]] | ||
| then | ||
| echo "[-] Usage: snap run rocketchat-server.rcrestore ${SNAP_COMMON}/backup_file.tgz" |
There was a problem hiding this comment.
@geekgonecrazy seems I overlooked this when I renamed the scripts.
Change:
echo "[-] Usage: snap run rocketchat-server.rcrestore ${SNAP_COMMON}/backup_file.tgz"
To:
echo "[-] Usage: snap run rocketchat-server.restoredb ${SNAP_COMMON}/backup_file.tgz"
There was a problem hiding this comment.
Ah! I missed too! Thanks will change
engelgabriel
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #5178
Add arm support to snaps. Many kudos to @elespike for his help on this! 👍
Need to test: