Convert irc package to js #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggazzo i will need your help testing this |
ggazzo
requested changes
May 24, 2017
| // message order could not make sure here | ||
| this.isConnected = true; | ||
| const messageBuf = this.msgBuf; | ||
| messageBuf.forEach(msg => { |
| } | ||
|
|
||
| createUserWhenNotExist(name) { | ||
| let user; |
There was a problem hiding this comment.
this logic is seem good, but at least use one line to declare and set the variable.
| }; | ||
|
|
||
| IrcClient.create = function(login) { | ||
| let ircClient; |
There was a problem hiding this comment.
declare where the variable is used. (line 389).
| const IRC_AVAILABILITY = RocketChat.settings.get('IRC_Enabled'); | ||
|
|
||
| // Cache prep | ||
| const net = Npm.require('net'); |
There was a problem hiding this comment.
I think that you should use import
|
@ggazzo fixed the things you mentioned |
ggazzo
previously requested changes
May 29, 2017
| return login; | ||
| }; | ||
|
|
||
| class IrcLoginer { |
| } | ||
| } | ||
|
|
||
| class IrcSender { |
|
|
||
| } | ||
|
|
||
| class IrcRoomJoiner { |
|
|
||
| } | ||
|
|
||
| class IrcRoomLeaver { |
|
|
||
| } | ||
|
|
||
| class IrcLogoutCleanUper { |
|
@haosdent @toxicgumbo could you help us to verify if this package still works? |
rodrigok
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core