Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] sweetalert alignment on mobile #7404

Merged
merged 3 commits into from Jul 4, 2017
Merged

[FIX] sweetalert alignment on mobile #7404

merged 3 commits into from Jul 4, 2017

Conversation

karlprieb
Copy link
Contributor

@RocketChat/core

Closes #7369

localhost-3000- iphone 6 plus

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7404 July 4, 2017 19:16 Inactive
geekgonecrazy
geekgonecrazy approved these changes Jul 4, 2017
View reviewed changes
Copy link
Member

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺 beautiful! I don't have to use mobile web or Cordova much.. but when I do this is an annoying bug

@geekgonecrazy
Copy link
Member

@karlprieb what about #7376 ?

@engelgabriel engelgabriel added this to the 0.58.0 milestone Jul 4, 2017
@karlprieb karlprieb changed the title Fix sweetalert alignment on mobile [FIX] sweetalert alignment on mobile Jul 4, 2017
@engelgabriel engelgabriel merged commit cdce18c into develop Jul 4, 2017
@engelgabriel engelgabriel deleted the sweetaler-responsive branch July 4, 2017 20:30
This was referenced Jul 5, 2017
Closed
Closed
@MartinSchoeler MartinSchoeler mentioned this pull request Jul 17, 2017
Closed
This was referenced Oct 20, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.58.0
Development

Successfully merging this pull request may close these issues.

Dialog boxes are not responsive (delete, upload, etc..)
3 participants
@karlprieb @geekgonecrazy @engelgabriel