Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Closes tab bar on mobile when leaving room #7561

Merged
merged 3 commits into from
Jul 26, 2017

Conversation

gdelavald
Copy link
Contributor

@RocketChat/core

Closes #7370

When leaving a room on mobile UI (screen less than 500px) it automatically closes the tab bar so when the user goes back to the room it's not open by default.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7561 July 24, 2017 19:38 Inactive
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the same subject, we should also close the flex-tab when clicking "go to message" button at "search flex tab":

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7561 July 24, 2017 21:45 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7561 July 25, 2017 17:36 Inactive
@rodrigok rodrigok added this to the 0.58.0 milestone Jul 26, 2017
@rodrigok rodrigok merged commit 978474e into develop Jul 26, 2017
@rodrigok rodrigok deleted the close-flextab-on-leave-room-mobile branch July 26, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Close flex-tab when opening a room on mobile UI
5 participants